CI do not assume test ansible controller has configured timezone #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolonaM
requested changes
Apr 14, 2023
Failed CI job https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4696220997/jobs/8326124886#step:8:49 The timezone from https://ipapi.co/timezone is correct one, it is based on public IP address/geolocation. But out test ansible controller is not configured with timezone. UTC is just OK for servers. We can convert unix epoch to local time with python and use pytz for that. pytz is used only for testing. The timezone from ipapi.co is not needed anymore. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
ci-fix-local-time-test
branch
from
47067cc to
b7b5af2
Compare
PolonaM
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed CI job
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4696220997/jobs/8326124886#step:8:49
The timezone from https://ipapi.co/timezone is correct one, it is based on public IP address/geolocation.
But out test ansible controller is not configured with timezone. UTC is just OK for servers.
We can convert unix epoch to local time with python and use pytz for that. pytz is used only for testing.
The timezone from ipapi.co is not needed anymore.
integ test after change:
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/4697144688