Adding vm_snapshot examples to collection

[domendobnikar]

• filter and delete based on special properties
• filter and delete based on timestamps

[domendobnikar]

@justinc1
vm_snapshot PR needs to be merged first. #217
Sanity issues are related to missing module.

[justinc1]

Minor changes.

The timezone is problematic, but if it is always UTC, than we just document this.

[domendobnikar]

We talked about adding a practical example of using uuid with vm_snapshot. @justinc1
I added examples with absent (using uuid) into both of these example playbooks.
Would something like this be enough? Or should I add a separate playbook that shows both preset and absent?

Fixed issues

[justinc1]

I'm worried get_snapshot() has small bug.

[justinc1]

Any chance to get a snapshot with correct label, but from a different VM?

It seems to me: filter to domainUUID=vm_object.uuid part is lost. And integration tests should be extended too.

[domendobnikar]

We pass VMobject as one of the parameters in this function.
It is then used with label for snapshot query if snapshot_uuid isn't passed as parameter to playbook.
The only added part was the if module.params["uuid"]: , everything else is the same. (code was taken from ensure_present function)
UUID is unique throughout the platform and use a different endpoint, it does not require any additional filtering by VM or label.

[domendobnikar]

I will extend integration tests to include the filtering by uuid part.
Good point 👍

[domendobnikar]

Integration tests:
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5003882224

[justinc1]

Added integration test - OK, thank you.

I think I didn't manage to describe what was potential problem. Say we have:

• vm_a, with snapshot:
  • snap_label_X, snap_uuid_a
• vm_b, with snapshot:
  • snap_label_X, snap_uuid_b

Then I try to task:

vm_snaptshot:
  vm_name: vm_a
  snapshot_uuid: snap_uuid_b

I think this case is not covered by current integration tests. In this case, module might continue to work with snap_uuid_b, but it should fail, vm_a has no snap_uuid_b.

[domendobnikar]

Oh okey, I misunderstood the problem.
I will extend tests to also cover that potential bug.

[domendobnikar]

Integration tests:
https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5014079719

[justinc1]

ty