Fix update status check #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On clean cluster version_update_status_info returns update_status=None Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
update_status_check taksfile now works also when update_status=None. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
anazobec
approved these changes
May 8, 2023
Collaborator
anazobec
left a comment
anazobec
left a comment
There was a problem hiding this comment.
Looks fixed. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a race condition. Sometimes a magic 60 sec delay was not enough to get update/update_status.json API endpoint work. The version_update_status_info now (it didn't initially) returns None in this case, so we can use that.