Cleanup unneeded condition #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version_update_status_info uses undocumented API endpoint, it is hard to know what is returned. I believe we wanted to have `==COMPLETE`, not `==COMPLETED`. I believe whole condition is there only to prevent starting second upgrade before the first one is finished - `.update_status != "IN PROGRESS"` is sufficient. A corner case would be if `.update_status == SOME_ERROR` or similar. In this case `!= "IN PROGRESS"` would still allow starting an upgrade. The `==COMPLETE` is again not needed - better to remove it, it just adds to confusion. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Collaborator
Author
|
A stupid question for @PolonaM - the |
Collaborator
|
Yes, it should never be COMPLETED, at least from what I saw, It is always COMPLETE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version_update_status_info uses undocumented API endpoint, it is hard to know what is returned. I believe we wanted to have
==COMPLETE, not==COMPLETED.I believe whole condition is there only to prevent starting second upgrade before the first one is finished -
.update_status != "IN PROGRESS"is sufficient.A corner case would be if
.update_status == SOME_ERRORor similar. In this case!= "IN PROGRESS"would still allow starting an upgrade. The==COMPLETEis again not needed - better to remove it, it just adds to confusion.