Skip to content

Conversation

@anazobec
Copy link
Collaborator

@anazobec anazobec commented May 8, 2023

Some VMs didn't want to receive a shutdown request, so version_update_single_node was updated so that the shutdown request is sent multiple times - in a loop.

@anazobec anazobec requested a review from justinc1 May 8, 2023 09:10
@anazobec anazobec self-assigned this May 8, 2023
@justinc1
Copy link
Collaborator

justinc1 commented May 8, 2023

For some reason Windows VMs sometimes ignore ACPI shutdown. Current PR would:

  • rapidly send multiple shutdown request
  • wait 300 sec on VMs to shutdown

It would be better if send shutdown is moved into wait on VM shutdown loop. So if some VM does not shutdown, then we retry shutdown. That is inside shutdown_vms.yml, move taks name: Shutdown running VMs into:

# Wait up to 300 sec (30*10)
- name: Wait until VMs shutdown
  include_tasks: wait_vm_shutdown.yml
  loop: "{{ range(0, 30) | list }}"
  when: version_update_all_vms_stopped | default(true)

Would that work?

Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will merge, and later test manually.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1 justinc1 merged commit ed18189 into main May 8, 2023
@justinc1 justinc1 deleted the fix-single-node-vm-loop-shutdown branch May 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants