Skip to content

Add shutdown destination VM functionallity before attaching a disk from a source snapshot. #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 16, 2023
Merged

Add shutdown destination VM functionallity before attaching a disk from a source snapshot. #233

merged 11 commits into from
May 16, 2023

Conversation

@anazobec
Copy link
Collaborator

@anazobec anazobec commented May 15, 2023

This PR makes sure that the VM we are trying to attach a snapshot disk to shuts down before attaching; tasks fail if we are trying to attach to a running VM.

How it works (steps):

  1. if the destination VM is running, shut it down (first normally, and if that fails, then forcibly) - this step is skipped if the VM is already shut down.
  2. attach the desired snapshot disk
  3. restart the destination VM.

@anazobec anazobec requested a review from justinc1 May 15, 2023 13:10
@anazobec anazobec self-assigned this May 15, 2023
anazobec
anazobec commented May 15, 2023
View reviewed changes
anazobec
anazobec commented May 15, 2023
View reviewed changes
justinc1
justinc1 reviewed May 15, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just comments

justinc1
justinc1 reviewed May 16, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

justinc1 added 7 commits May 16, 2023 14:05
@justinc1
Document user is responsible to select next free slot on specific dis…
092a2ba 
…k bus

Otherwise disk is attached, but VM is not bootable.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Update module might reboot VM
e7fe429 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
CI faster testing
9b501c9 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Comment about test side effect
37c4c65 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Fix test for attaching snapshoted disk to the same VM
13ae756 
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
The destination VM can be created by vm module
fb9659c 
The destination VM does not need snapshots.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Revert some changes in helper_api_vm_snapshot_create.yml
a293057 
But having those VMs in running state is a good idea.
It makes things harder.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
justinc1 approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@justinc1 justinc1 merged commit 03bc1aa into main May 16, 2023
@justinc1 justinc1 deleted the add-vm-shutdown-to-vm-snapshot-attach-disk branch May 16, 2023 12:26
@anazobec anazobec mentioned this pull request May 16, 2023
Merged
@justinc1 justinc1 mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinc1 justinc1 justinc1 approved these changes

Assignees

@anazobec anazobec

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anazobec @justinc1