Example - test vm os upgrade #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinc1
reviewed
May 16, 2023
Collaborator
justinc1
left a comment
justinc1
left a comment
There was a problem hiding this comment.
Minor changes are needed. The cloned VM must already contain the index.html - it was in source VM when snapshot was created. And we should show how to assign a diffrent VLAN to the cloned VM NIC.
PolonaM
force-pushed
the
example-test-vm-os-upgrade
branch
4 times, most recently
from
3b693e1 to
4a7f190
Compare
justinc1
approved these changes
May 18, 2023
Collaborator
justinc1
left a comment
justinc1
left a comment
There was a problem hiding this comment.
Just two trivial changes. We got clone from snaphost merged into main, so we can use it.
PolonaM
force-pushed
the
example-test-vm-os-upgrade
branch
from
849a1ba to
9319f7c
Compare
justinc1
approved these changes
May 19, 2023
Collaborator
justinc1
left a comment
justinc1
left a comment
There was a problem hiding this comment.
I will add one trivial change.
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
PolonaM
force-pushed
the
example-test-vm-os-upgrade
branch
from
adc87d0 to
df34627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.