Skip to content

Conversation

@anazobec
Copy link
Collaborator

@anazobec anazobec commented May 17, 2023

Examples testing job was always run before the integration testing job which made waiting for integration tests to finish even longer then it was supposed to. This pull request fixes this problem by updating the examples-run job to make it run after the integ job finishes regardless of the status.

Jobs examples-run and integ can be found in .github/workflows/integ-test.yml.

Tests:

1. Test if examples-run is run after integ job succeeds:

https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5003937671
Timestamp of the last integration test to succeed (here):

Run echo "Integ time -> $(date +%T)" && exit 0
Integ time -> 13:44:08

Timestamp of the first example test to run (here):

Run echo "Integ time -> $(date +%T)"
Integ time -> 13:44:30

2. Test if examples-run is run after integ job fails:

https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5004006697
Timestamp of the last integration test to fail (here):

Run echo "Integ time -> $(date +%T)" && exit 1
Integ time -> 13:51:26
Error: Process completed with exit code 1.

Timestamp of the first example test to run (here):

Run echo "Integ time -> $(date +%T)"
Integ time -> 13:51:44

anazobec added 5 commits May 17, 2023 16:01
Test

Test-2

Test-2

Test-3

Test-4
Test integ-test workflow

Test integ-test workflow 2

Test integ-test workflow 3

Test integ-test workflow 4

Test integ-test workflow 5
@anazobec anazobec self-assigned this May 17, 2023
@anazobec anazobec requested a review from justinc1 May 17, 2023 14:19
@anazobec anazobec changed the title Make examples testing job run before integration tests Make examples testing job run after integration tests May 17, 2023
@justinc1
Copy link
Collaborator

I will move moved block back to old position, to get smaller diff.

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
@justinc1
Copy link
Collaborator

justinc1 commented May 18, 2023

Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinc1 justinc1 merged commit 6a17236 into main May 18, 2023
@justinc1 justinc1 deleted the fix-example-testing-ci-jobs branch May 18, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants