OIDC login #238
Merged
OIDC login #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned sessionID is then sent in subsequent requests. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
The oidc_config was tested there a while ago, so we have OIDC configured. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Collaborator
Author
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Do not change SC_AUTH_METHOD to oidc if OIDC is not configured. Cleanup will fail if we do this. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
PolonaM
approved these changes
May 19, 2023
Collaborator
PolonaM
left a comment
PolonaM
left a comment
There was a problem hiding this comment.
Thank you! I have only comments about the documentation
domendobnikar
approved these changes
May 19, 2023
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR allows collection to login to HyperCore cluster using a username form external OIDC provider. New environ varibale
SC_AUTH_METHOD(possible value None/unset,localoroidc) is added as we need to know where is user defined.Previously we used HTTP basic login for each request. PR first refactored code to get sessionID from HC3 and reuse it for subsequent requests.
Since OIDC is configured on .50 test cluster only, the CI job
utils_loginwill be run only there.The inventory plugin will run on .200 and .201 VSNS (just as before). But since we do not test OIDC on VSNS, OIDC is not configured there, so now we test inventory plugin on .50 also, and there (and only there) inventory plugin with OIDC user is tested.