use ansible-core 2.15 for testing #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I expected this will just work, but CI jobs do fail - see https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5021283389/jobs/9003506210. I can reproduce locally in docker container: The integration tests do pass, the code does work (v1.2.0 we just released is safe for users). |
anazobec
approved these changes
May 19, 2023
Collaborator
anazobec
left a comment
anazobec
left a comment
There was a problem hiding this comment.
I will approve this PR, since it does seem the code does indeed still work and is safe to use.
justinc1
force-pushed
the
test-with-ansible-core-2.15
branch
6 times, most recently
from
9714b44 to
92fefda
Compare
We also need up to date ansible-lint, and our docker image C.UTF-8 lang seems to be needed. For problem, see job https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5022602745/jobs/9006262055?pr=239 Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Add after `run_main(cluster_name, params)`
+ import q
+ q(success, result)
And in /tmp/q we get error message:
result={'msg': "argument 'username' is of type <class 'NoneType'> found in 'cluster_instance'. and we were unable to convert to str: 'None' is not a string and conversion is not allowed"
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
name is required, source is not. Ansible (2.15) does not like name=None
in unit test (but source=None is OK).
Replace None with "", then deduplicate list. There were no duplicates!
Also fix typo in
name=file_location_test
source=file_name_test
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
See https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5023094955/jobs/9007305282?pr=239#step:4:1205 cloud_init option: seems default values was always None before ansible-core 2.15, now it is {} if type=dict. vm module disks and nics option, vm_nic module items option - actual default value in argument_spec is not changed. Commit changes only documentation, to comply with argument_spec. Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
variables in roles are not yet renamed Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
test-with-ansible-core-2.15
branch
from
92fefda to
b6d644a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ansible-core 2.15 for tests. Docker image for CI jobs was rebuilt and pushed to quay.io.