Skip to content

Conversation

@anazobec
Copy link
Collaborator

The purpose of this PR is, to make the integration tests that are skipped by default run sequentially after the integ job.
For this, another job was added: integ-sequentially.

@anazobec anazobec requested a review from justinc1 May 23, 2023 12:57
@anazobec anazobec self-assigned this May 23, 2023
@anazobec
Copy link
Collaborator Author

I've run integration tests to check if those skipped integration tests actually do run sequentially now. They do.
These are the integration tests: https://github.com/ScaleComputing/HyperCoreAnsibleCollection/actions/runs/5118335574

Note: These integration tests were run on commit 4adb6e1.

Here are the timestamps of each integration test start to make it easier to see the results.

  • vm_node_affinity (200) -> 6.36.48
  • vm_node_affinity (201) -> 6.37.01
  • node_info (.200) -> 6.37.14
  • node_info (.201) -> 6.37.27
  • dns_config -> 6.37.40
  • cluster_shutdown -> 6.37.53
  • version_update -> 6.38.06
  • oidc_config -> 6.38.19
  • smtp -> 6.38.32
  • role_cluster_config -> 6.38.45
  • role_version_update_single_node -> 6.38.58
  • utils_login -> 6.39.11

When each of the tests finished, there was a bit of a delay and then the next one started as expected.

justinc1 added 9 commits June 1, 2023 12:30
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
github UI is unreadable

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
OIDC is not fully configured (client id is just "todo")

Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Copy link
Collaborator

@justinc1 justinc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty.

I added some minor changes. Test certificate module in sequential job. With OIDC configured on VSNSs, we can test there also inventory plugin with OIDC login.

@justinc1 justinc1 merged commit 3b6c5d1 into main Jun 1, 2023
@justinc1 justinc1 deleted the make-skipped-integs-run-sequentially branch June 1, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants