-
Notifications
You must be signed in to change notification settings - Fork 79
Create latest releases for CLI, go-scalingo and terraform-provider-scalingo #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create latest releases for CLI, go-scalingo and terraform-provider-scalingo #3350
Conversation
sc-zenokerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions / questions
|
|
||
| ### Changelog | ||
|
|
||
| Some features listed in this changelog, like private networks, are currently only available to selected users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: This is a good message.
| github: 'https://github.com/Scalingo/go-scalingo' | ||
| --- | ||
|
|
||
| ### Changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the same message from the cli changelog to the sdk also?
Some features listed in this changelog, like private networks, are currently only available to selected users.
What do you think about adding it to the previous changelog entry in sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll do both 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(actually it's only in the 8.6.0, nothing else)
sc-zenokerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I also created the 1.39 release not for the CLI, which was missing.