feat(oci8): support oci8 extensions
#291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinEscudierScalingo
force-pushed
the
feat/290/support_oci8_extension
branch
2 times, most recently
from
08c2a5f to
bf775b0
Compare
|
A php sample that install oci8: https://github.com/QuentinEscudierScalingo/sample-php |
QuentinEscudierScalingo
force-pushed
the
feat/290/support_oci8_extension
branch
from
bf775b0 to
db3894b
Compare
Soulou
reviewed
Jan 23, 2023
There was a problem hiding this comment.
In your example app, you have
https://github.com/QuentinEscudierScalingo/sample-php/blob/master/Aptfile#L1
Is it mandatory here?
If yes, the buildpack should check the presence of the library and fails with the right instruction if it's not present.
|
The lib |
QuentinEscudierScalingo
force-pushed
the
feat/290/support_oci8_extension
branch
4 times, most recently
from
47db099 to
651aee7
Compare
…ibaio installed via apt buildpack libaio and oracle-client must be cached to avoid download at each deploy
QuentinEscudierScalingo
force-pushed
the
feat/290/support_oci8_extension
branch
from
651aee7 to
1ee469d
Compare
QuentinEscudierScalingo
changed the base branch from
fix/249/pecl_extensions
to
master
QuentinEscudierScalingo
changed the base branch from
master
to
fix/249/pecl_extensions
Soulou
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done:
libaiovia the APT builpackWhat's left to do:
libaioshould be fixedFix #290