Bump prettier to 3.0.3 and fix warnings

 - add a separate eslint step to the git hub workflow
 - adjust configuration
 - use same settings for prettier as in BE

Supersedes: #1193
Change-Id: I708d15c06c24503eb0cddc7fdf15b237a57b7071

Author: bpedersen2

.eslintrc.json

@@ -1,22 +1,18 @@
 {
   "root": true,
-  "ignorePatterns": [
-    "projects/**/*"
-  ],
+  "ignorePatterns": ["projects/**/*"],
+  "plugins": ["@typescript-eslint/eslint-plugin"],
   "overrides": [
     {
-      "files": [
-        "*.ts"
-      ],
+      "files": ["*.ts"],
       "parserOptions": {
-        "project": [
-          "tsconfig.json"
-        ],
+        "project": ["tsconfig.json"],
         "createDefaultProgram": true
       },
       "extends": [
-	"eslint:recommended", 
-	"plugin:@typescript-eslint/recommended",      
+        "eslint:recommended",
+        "plugin:prettier/recommended",
+        "plugin:@typescript-eslint/recommended",
         "plugin:@angular-eslint/recommended",
         "plugin:@angular-eslint/template/process-inline-templates"
       ],
@@ -70,15 +66,8 @@
         "@typescript-eslint/naming-convention": [
           "error",
           {
-            "format": [
-              "camelCase",
-              "snake_case",
-              "UPPER_CASE"
-            ],
-            "selector": [
-              "variable",
-              "function"
-            ]
+            "format": ["camelCase", "snake_case", "UPPER_CASE"],
+            "selector": ["variable", "function"]
           }
         ],
         "@typescript-eslint/no-inferrable-types": "error",
@@ -89,32 +78,17 @@
             "allowTemplateLiterals": true
           }
         ],
-        "@typescript-eslint/semi": [
-          "error",
-          "always"
-        ],
-        "brace-style": [
-          "error",
-          "1tbs"
-        ]
+        "@typescript-eslint/semi": ["error", "always"]
       }
     },
     {
-      "files": [
-        "*.html"
-      ],
-      "extends": [
-        "plugin:@angular-eslint/template/recommended"
-      ],
+      "files": ["*.html"],
+      "extends": ["plugin:@angular-eslint/template/recommended"],
       "rules": {}
     },
     {
-      "files": [
-        "*.ts"
-      ],
-      "extends": [
-        "plugin:ngrx/recommended"
-      ]
+      "files": ["*.ts"],
+      "extends": ["plugin:ngrx/recommended"]
     }
   ]
 }

.github/workflows/test.yml

@@ -8,6 +8,36 @@ env:
   NODE_VERSION: 18.x
 
 jobs:
+
+
+  prettier-and-eslint:
+    name: prettier and eslint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out Git repository
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Cache node_modules
+        id: cached-node-modules
+        uses: actions/cache@v3
+        with:
+          path: node_modules
+          key: node-modules-${{ hashFiles('package-lock.json') }}-${{ env.NODE_VERSION }}
+
+      - name: Run prettier
+        uses: actionsx/prettier@v2
+        with:
+          # prettier CLI arguments.
+          args: --check "src/**/*.ts" "test/**/*.ts"
+
+      - name: run eslint
+        run: npm run lint
+
   test:
     name: Run tests
     runs-on: ubuntu-latest

.prettierrc

@@ -0,0 +1,7 @@
+{
+  "bracketSpacing": true,
+  "singleQuote": false,
+  "printWidth": 80,
+  "trailingComma": "all",
+  "arrowParens": "always"
+}