Skip to content

Conversation

@martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Mar 17, 2023

Description

  • Add error notification for all errors and success notification on POST, PUT, PATCH or DELETE successful action.
  • Improve attachments layout and include download button. (covered this with e2e tests)

Motivation

There was no feedback if error occurred or something went successfully. Also no way to download attachments.

Fixes:

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@martin-trajanovski martin-trajanovski changed the title feat: add attachments accepted formats and show success and error not… feat: add attachments accepted formats and show success and error notification on each action Mar 20, 2023
@martin-trajanovski martin-trajanovski self-assigned this Mar 20, 2023
@martin-trajanovski martin-trajanovski marked this pull request as ready for review March 20, 2023 12:50
@nitrosx nitrosx merged commit 572d3fc into master Mar 20, 2023
@nitrosx nitrosx deleted the SWAP-3151-attachment-improvements branch March 20, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants