Skip to content

Conversation

@MaxBetzDLR
Copy link
Member

@MaxBetzDLR MaxBetzDLR commented Aug 8, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Add return value policy to TimeSeries in python bindings

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1343

@MaxBetzDLR MaxBetzDLR self-assigned this Aug 8, 2025
@MaxBetzDLR MaxBetzDLR added class::bug Bugs found in the software loc::python interface This issue concerns the python interface to the backend implementation. labels Aug 8, 2025
@MaxBetzDLR MaxBetzDLR linked an issue Aug 8, 2025 that may be closed by this pull request
2 tasks
@MaxBetzDLR MaxBetzDLR added the loc::data handling This issue concerns any kind of data handling. label Aug 8, 2025
@MaxBetzDLR MaxBetzDLR requested a review from charlie0614 August 8, 2025 11:52
@charlie0614 charlie0614 merged commit c6023dd into main Aug 8, 2025
55 checks passed
@charlie0614 charlie0614 deleted the 1343-fix-lifetime-of-timeseries-in-python-pyndings branch August 8, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::bug Bugs found in the software loc::data handling This issue concerns any kind of data handling. loc::python interface This issue concerns the python interface to the backend implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix lifetime of TimeSeries in python pyndings

3 participants