Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Mar 23, 2023

Changes

Added an option to read a graph without edges. Especially useful for the create_graph_without_edges function.

Merge Request - GuideLine Checklist

  • Check our git workflow before opening a Pull request/Merge request.
  • Request a reviewer when your work is ready to review, before this please use the draft feature.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Additional context

Please list additional information or things a reviewer should look out for.

Closes #596

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 76.47% and project coverage change: +0.12 🎉

Comparison is base (109766a) 93.07% compared to head (b114caf) 93.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   93.07%   93.19%   +0.12%     
==========================================
  Files          93       93              
  Lines        7290     7291       +1     
==========================================
+ Hits         6785     6795      +10     
+ Misses        505      496       -9     
Impacted Files Coverage Δ
cpp/memilio/io/mobility_io.h 87.09% <76.47%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HenrZu HenrZu requested a review from jubicker March 23, 2023 15:22
HenrZu and others added 2 commits March 27, 2023 16:16
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
@HenrZu HenrZu requested a review from jubicker March 27, 2023 15:05
@jubicker jubicker merged commit a789002 into main Mar 29, 2023
@jubicker jubicker deleted the 596-read-graph-without-edges branch March 29, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Graphs created with create_graph_without_edges are not readable with read_graph

4 participants