Fix recursive_eltype not defined when constructing ComponentArray on the GPU
#210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 73.00% 73.00%
=======================================
Files 20 20
Lines 689 689
=======================================
Hits 503 503
Misses 186 186
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
Thanks for this! It looks like the test failure is unrelated, so I'm gonna fix that really quick. |
jonniedie
approved these changes
Jun 17, 2023
Collaborator
|
Okay, this should be good to go with the new changes. If you wouldn't mind rebasing I can merge after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After the switch to Julia extensions (#192), the methods that are not exported by ComponentArrays are not accessible in the extension source files. This leads to an undefined reference when calling
recursive_eltypeat line 77 in the constructor of ComponentArray on the GPU:https://github.com/jonniedie/ComponentArrays.jl/blob/97eb9e3db7904ea13b823403d00ddd9e9d6c078f/ext/ComponentArraysGPUArraysExt.jl#L76-L81
This pull request adds the missing import and fixes #209.