Avoiding Type Piracy in Lux #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 73.88% 74.09% +0.20%
==========================================
Files 23 25 +2
Lines 743 772 +29
==========================================
+ Hits 549 572 +23
- Misses 194 200 +6 ☔ View full report in Codecov by Sentry. |
1 task
Member
Author
|
@jonniedie let me know if there is any patch you don't want here. |
Member
Author
|
Bump |
jonniedie
approved these changes
Mar 19, 2024
Collaborator
jonniedie
left a comment
jonniedie
left a comment
There was a problem hiding this comment.
Thanks for doing this! Sorry it took me so long to get to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time before package extensions, I had put in hacks in Lux to make several of the DL packages play well with ComponentArrays. We moved some of them here before, but some still remained and it seems bad to have a different behavior for these packages before and after Lux is loaded.
I am moving those patches here. Let, me know if there is an objection regarding any of them.
TODOs
ComponentArray(::NamedTuple)Fixes LuxDL/Lux.jl#482