API function for kwarg merging #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hmm looks like this does break some other tests currently. |
Member
Author
|
@ChrisRackauckas i think this is good. The failures all fail on master generally, so I don’t think are related to this. |
isaacsas
commented
Nov 21, 2025
isaacsas
commented
Nov 21, 2025
ChrisRackauckas
approved these changes
Nov 22, 2025
Member
|
Yeah, Zygote in general is broken, so I need to figure out what to do there... move all tests to Mooncake ASAP? That's a next week problem. |
Member
Author
|
Can we get a DiffEqBase release too? |
Member
|
I thought one already happened? |
Member
Author
|
Thanks! When I made the comment the Project.toml hadn’t been updated and the last listed release was from two weeks ago. On Nov 22, 2025, at 12:33 PM, Christopher Rackauckas ***@***.***> wrote:ChrisRackauckas left a comment (SciML/DiffEqBase.jl#1224)
I thought one already happened?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors the kwarg merging code out of
init_callandsol_callso we can reuse it in JumpProcesses (and slightly tweaks the code). Tests are also added.If it is relevant, this was generated going back and forth with Claude, but it seems reasonable to me and tests pass locally.