Use a nudge factor to remove repeats #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes simple is better. Instead of using a derivative estimate, now we just check at t + dt * repeat_nudge to avoid repeated zeros, with a default to 1//100 which seems to be a nice balance between numerical stability and keeping most of the interval still an eventful zone. Fixes SciML/DifferentialEquations.jl#758
Member
Author
Member
Author
Member
Author
Member
Author
YingboMa
approved these changes
Jun 18, 2021
Member
YingboMa
left a comment
YingboMa
left a comment
There was a problem hiding this comment.
It's impressive that this works so well.
devmotion
reviewed
Jun 18, 2021
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Member
|
BTW the GPU tiemouts are caused by CUDA 3.3 but fixed on master: https://julialang.slack.com/archives/C689Y34LE/p1623939645188500 AFAIK a new release will be available soon (possibly today). |
Member
Author
|
Awesome, those were confusing me but I at least figured out it was unrelated to this (because those don't test callbacks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes simple is better. Instead of using a derivative estimate, now we just check at t + dt * repeat_nudge to avoid repeated zeros, with a default to 1//100 which seems to be a nice balance between numerical stability and keeping most of the interval still an eventful zone.
Fixes SciML/DifferentialEquations.jl#758
Fixes SciML/DifferentialEquations.jl#647
Fixes SciML/DifferentialEquations.jl#724
Fixes SciML/DifferentialEquations.jl#601
Fixes SciML/DifferentialEquations.jl#642
Fixes #599