Fix exp_generic for general AbstractMatrix. #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a couple oversights and adding tests to make sure
StaticArrays.MMatrixstill works, as an example generic mutable AbstractArray.Those oversights were:
Base.Experimental.Constis only defined forArray.lu!is only defined forStridedMatrix.MMatrixdoesn't subtype strided, and also does not returnLinearAlgebra.LU, returningStaticArrays.LUinstead. The latter doesn't supportrdiv!.While it'd be nice to fix "2." in
StaticArrays, for now it's easiest to just work around it here.