Skip to content

Remove TriangularSolve dependency #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2025
Merged

Remove TriangularSolve dependency #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1ad96d
Remove TriangularSolve dependency
ChrisRackauckas Nov 12, 2025
2cb7d42
Update LinearSolveRecursiveFactorizationExt.jl
ChrisRackauckas Nov 12, 2025
78a9a69
Update LinearSolveRecursiveFactorizationExt.jl
ChrisRackauckas Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ SciMLLogging = "a6db7da4-7206-11f0-1eab-35f2a5dbe1d1"
SciMLOperators = "c0aeaf25-5076-4817-a8d5-81caf7dfa961"
Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c"
TriangularSolve = "d5829a12-d9aa-46ab-831f-fb7c9ab06edf"
UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"

[weakdeps]
Expand Down Expand Up @@ -139,7 +138,6 @@ StableRNGs = "1.0"
StaticArrays = "1.9"
StaticArraysCore = "1.4.3"
Test = "1.10"
TriangularSolve = "0.2.1"
UnPack = "1.0.2"
Zygote = "0.7"
blis_jll = "0.9.0"
Expand Down
6 changes: 4 additions & 2 deletions ext/LinearSolveRecursiveFactorizationExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ using LinearSolve: LinearSolve, userecursivefactorization, LinearCache, @get_cac
using LinearSolve.LinearAlgebra, LinearSolve.ArrayInterface, RecursiveFactorization
using SciMLBase: SciMLBase, ReturnCode
using SciMLLogging: @SciMLMessage
using TriangularSolve

LinearSolve.userecursivefactorization(A::Union{Nothing, AbstractMatrix}) = true

Expand Down Expand Up @@ -132,7 +131,10 @@ function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::ButterflyFactoriz
(;A, b, ws, U, V, out, tmp, n) = workspace
b[1:M] .= cache_b
mul!(tmp, U', b)
TriangularSolve.ldiv!(F, tmp, thread)

# TriangularSolve.ldiv!
RecursiveFactorization.ldiv!(F, tmp, thread)

Copy link
Contributor

@github-actions github-actions bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

mul!(b, V, tmp)
out .= @view b[1:n]
SciMLBase.build_linear_solution(alg, out, nothing, cache)
Expand Down
Loading