Fix unexpected pass for Broyden Wood function test on Julia 1.12+ #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test #4 (Wood function) for SimpleBroyden() now passes on Julia 1.12+ on macOS. Updated the broken_tests logic to exclude test #4 from broken tests on v1.12+. The test was previously marked as broken on v1.11+ but is now passing on v1.12+, likely due to improvements in Julia 1.12 that fixed the underlying issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an "Unexpected Pass" test error on Julia 1.12+ by updating the broken tests list for the Broyden solver.
Issue
Test #4 (Wood function) for SimpleBroyden() was marked as
@test_brokenon Julia 1.11+ on macOS, but it now passes on Julia 1.12+. This caused the CI to fail with an "Unexpected Pass" error.Changes
Updated the
broken_testslogic intest/23_test_problems_tests.jlto:Root Cause
The test is now passing on v1.12+ likely due to improvements in Julia 1.12 that fixed the underlying numerical issue.
Test plan
🤖 Generated with Claude Code