Fix Sophia optimizer: add Random import to resolve randn! error #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Sophia optimizer calls randn!() on line 155 of src/sophia.jl but Random was not imported. This caused UndefVarError when using Sophia. Changes: - Add Random to dependencies in Project.toml - Import Random in src/Optimization.jl Fixes SciML#1004 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1004 where the Sophia optimizer was throwing
UndefVarError: randn! not defined in Optimizationwhen used.Problem
The Sophia optimizer calls
randn!(u)on line 155 ofsrc/sophia.jlto generate random vectors for the Hutchinson trace estimator, butRandomwas not imported into theOptimizationmodule namespace.Solution
Randomas a dependency inProject.tomlusing Randomto the imports insrc/Optimization.jlTesting
randn!call without errorsThe changes are minimal and focused, only adding the necessary Random import to resolve the missing function error.
Test plan
randn!errorFixes #1004
🤖 Generated with Claude Code