Fix issparse for AbstractVectorOfArray #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SciML#486 When issparse(::SubArray) is called, it tries to call issparse on the parent array. If the parent is an AbstractVectorOfArray, there was no issparse method defined, causing a MethodError. This commit adds issparse method that returns false for AbstractVectorOfArray, since it is not a sparse array type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds comprehensive tests for the issparse method including: - Testing issparse returns false for VectorOfArray - Testing issparse returns false for DiffEqArray - Testing the original issue with SubArray views - Testing nested VectorOfArray structures 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #486
This PR adds the
issparsemethod forAbstractVectorOfArray, resolving aMethodErrorthat occurred whenissparse(::SubArray)tried to callissparseon its parent array.Changes
Added
issparsemethod inRecursiveArrayToolsSparseArraysExt.jlfalseforAbstractVectorOfArraysince it is not a sparse array typeAdded comprehensive tests in
test/interface_tests.jlissparsereturnsfalseforVectorOfArrayissparsereturnsfalseforDiffEqArraySubArrayviewsVectorOfArraystructuresTest Results
All tests pass successfully. The fix resolves the error described in the issue:
Checklist
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com