Skip to content

feat: add warning in weighted_init for change of res_size #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

feat: add warning in weighted_init for change of res_size #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab7b8f
feat: add warning in weighted_init for change of res_size
MartinuzziFrancesco Mar 23, 2025
3d72208
chore: up DifferentialEquations version
MartinuzziFrancesco Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Adapt = "4.1.1"
Aqua = "0.8"
CellularAutomata = "0.0.2"
Compat = "4.16.0"
DifferentialEquations = "7.15.0"
DifferentialEquations = "7.16.1"
LIBSVM = "0.8"
LinearAlgebra = "1.10"
MLJLinearModels = "0.9.2, 0.10"
Expand Down
8 changes: 8 additions & 0 deletions src/esn/esn_inits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ function weighted_init(rng::AbstractRNG, ::Type{T}, dims::Integer...;
throw_sparse_error(return_sparse)
approx_res_size, in_size = dims
res_size = Int(floor(approx_res_size / in_size) * in_size)
if res_size != approx_res_size
@warn """Reservoir size has changed!\n
Computed reservoir size ($res_size) does not equal the \
provided reservoir size ($approx_res_size). \n
Using computed value ($res_size). Make sure to modify the \
reservoir initializer accordingly. \n
"""
end
layer_matrix = DeviceAgnostic.zeros(rng, T, res_size, in_size)
q = floor(Int, res_size / in_size)

Expand Down
Loading