Add helper functions for AbstractSciMLFunction #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=========================================
- Coverage 3.09% 3.01% -0.08%
=========================================
Files 37 37
Lines 2520 2584 +64
=========================================
Hits 78 78
- Misses 2442 2506 +64
Continue to review full report at Codecov.
|
src/scimlfunctions.jl
Outdated
| has_Wfact_t(f::AbstractDiffEqFunction) = __has_Wfact_t(f) && f.Wfact_t !== nothing | ||
| has_paramjac(f::AbstractDiffEqFunction) = __has_paramjac(f) && f.paramjac !== nothing | ||
| has_syms(f::AbstractDiffEqFunction) = __has_syms(f) && f.syms !== nothing | ||
| has_colorvec(f::AbstractDiffEqFunction) = __has_colorvec(f) && f.colorvec !== nothing |
Member
There was a problem hiding this comment.
delete these ones since AbstractDiffEqFunction <: AbstractSciMLFunction
Member
|
I guess it would make sense to remove the definitions for |
ChrisRackauckas
pushed a commit
that referenced
this pull request
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisRackauckas