Avoid reset macro on AddedOperator update and caching #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
|
The OrdinaryDiffEq tests should not be related to this PR. I have tested the locally with the stable version of SciMLOperators.jl and still fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
When differentiating an ODE with Zygote, I was having an error at the point where
cache_operatorwas called. Appartently Zygote doesn't like the@resetmacro.See for example these errors:
https://github.com/qutip/QuantumToolbox.jl/actions/runs/19443089834/job/55630970771?pr=596
Here I avoid it using generated function. This should also make the code more robust on more structured AddedOperators.