Update Sundials common interface #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/API/arkode.jl
Outdated
| end | ||
|
|
||
| function ARKStepSetLinearSolver(arkode_mem, LS::SUNLinearSolver, A::SUNMatrix) | ||
| function ARKStepSetLinearSolver(arkode_mem, LS::SUNLinearSolver, A) |
There was a problem hiding this comment.
it's always dangerous directly modifying the wrapped API files. Instead, make an API additions file for these dispatches.
There was a problem hiding this comment.
We can add some conversion method for these function and have a similar behavior as N_Vector and NVector also.
ChrisRackauckas
approved these changes
Apr 5, 2020
|
Mac CIs seem to have stuck, so I will merge this PR. |
|
Mac CI is terrible. We can probably turn those off once we're comfortable the binaries work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.