Skip to content

Conversation

@spacewander
Copy link

This pr is about issue #189, which succeeds #334

@translunar
Copy link
Member

@spacewander Can you include some specs with Yale 3x3 matrices with more zeros? I think your tests are providing full coverage, but I'm not one hundred percent certain.

@spacewander
Copy link
Author

No problem.

@translunar
Copy link
Member

@spacewander Any progress on this?

@spacewander
Copy link
Author

Oh yes, I have added a new case to this pr:

c = NMatrix.new(3, [1,0,3,0,0,1,0,6,0], stype: :yale, dtype: :int64)
inversed = c.method(:__inverse_exact__).call(c.clone, 3, 3)
d = NMatrix.new(3, [1,-3,0,0,0,0,0,1,0], stype: :yale, dtype: :int64)
expect(inversed).to eq(d)

And the code can work properly.

Is it enough?

end

it "calculates exact determinants on small square matrices" do
it "calculates exact determinants on small dense matrices" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

square dense

@translunar
Copy link
Member

Overcome by #580.

@translunar translunar closed this Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants