Skip to content

Conversation

@yoongkang
Copy link

I'm trying to pick up where @MpoMp left off with #204. Basically minor modifications to the specs because I don't feel there is much of a point of comparing exact values of floating point numbers.

@yoongkang
Copy link
Author

Well that didn't go well. I'll look at them when I get home.

@yoongkang
Copy link
Author

Got them passing.

@translunar
Copy link
Member

Hey, could you please rebase into a single commit?

@yoongkang
Copy link
Author

Sure. I didn't want to squash @MpoMp's commits, but I suppose you could add his name to the changelog.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be called matrix_norm instead of norm, so people won't get it confused with the vector norm (since NMatrix also supports vectors).

Credit goes to @MpoMp for the implementation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem with nrm2? Can you file a bug on this? Maybe you should avoid using nrm2 since it doesn't work for complex types either (#389).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly do not know. From the commit history at the other pull request (see #204) it seems that @MpoMp used nrm2 at some stage and changed it later but the reasoning wasn't documented.

I'd be happy to look into it though. But it won't be tonight.

@translunar
Copy link
Member

Bumping this almost-completed pull request to the top for GSOC students who'd like to finish it. :)

@npriyadarshi
Copy link

@MohawkJohn I would like to work on this one if nobody is already doing it.

@translunar
Copy link
Member

Go for it.

@npriyadarshi npriyadarshi mentioned this pull request Mar 15, 2017
@translunar
Copy link
Member

Oops, think this was closed by #586. Correct me if I'm wrong.

@translunar translunar closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants