-
Notifications
You must be signed in to change notification settings - Fork 134
Norms #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Norms #400
Conversation
|
Well that didn't go well. I'll look at them when I get home. |
|
Got them passing. |
|
Hey, could you please rebase into a single commit? |
|
Sure. I didn't want to squash @MpoMp's commits, but I suppose you could add his name to the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be called matrix_norm instead of norm, so people won't get it confused with the vector norm (since NMatrix also supports vectors).
Credit goes to @MpoMp for the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the problem with nrm2? Can you file a bug on this? Maybe you should avoid using nrm2 since it doesn't work for complex types either (#389).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Bumping this almost-completed pull request to the top for GSOC students who'd like to finish it. :) |
|
@MohawkJohn I would like to work on this one if nobody is already doing it. |
|
Go for it. |
|
Oops, think this was closed by #586. Correct me if I'm wrong. |
I'm trying to pick up where @MpoMp left off with #204. Basically minor modifications to the specs because I don't feel there is much of a point of comparing exact values of floating point numbers.