fixes inverse_exact methods for dense, yale and list stype #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translunar
requested changes
Mar 21, 2017
lib/nmatrix/math.rb
Outdated
| # * *Raises* : | ||
| # - +DataTypeError+ -> cannot invert an integer matrix in-place. | ||
| # - +NotImplementedError+ -> cannot find exact inverse of matrix with size greater than 3 # | ||
| def invert_exact! |
Member
There was a problem hiding this comment.
I think we should probably alias this as invert_exactly! and name it exact_inverse! instead. invert_exact! is not a good name.
FYI, you can make these changes and then do a git commit -a --amend followed by a git push --force if you want to update the pull request instead of having to open a brand new one every time.
Author
There was a problem hiding this comment.
@MohawkJohn I have made the changes you asked for.
and thank you for letting me know about those command. i will keep that in mind .
lib/nmatrix/math.rb
Outdated
| # - +ShapeError+ -> matrix must be square. | ||
| # - +NotImplementedError+ -> cannot find exact inverse of matrix with size greater than 3 | ||
| # | ||
| def invert_exact |
translunar
approved these changes
Mar 21, 2017
Author
|
Is that all? |
Member
|
Wait until I'm near a computer again or get one of the other maintainers to
merge it. @v0dro, maybe?
…On Tue, Mar 21, 2017 at 4:45 PM Navneet Priyadarshi < ***@***.***> wrote:
what do i have to do to get this merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#585 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKFpLmf0u3k524y0LbEQcYVHCx1IAx8ks5roEUBgaJpZM4MeHLF>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MohawkJohn I have made some changes in the specs which was incorrectly done in #580 . Hope this one works. Replaces #581 #569 #444 #582 .