add end time

[leonleonyu]

PR Type

Enhancement

---

Description

• Add EndTime property to ConversationFilter class

• Implement end time filtering in MongoDB conversation repository

---

Diagram Walkthrough

flowchart LR
  A["ConversationFilter"] -- "add EndTime property" --> B["Enhanced Filter"]
  B -- "implement filtering logic" --> C["MongoDB Repository"]
  C -- "filter by CreatedTime <= EndTime" --> D["Filtered Conversations"]

Loading

File Walkthrough

Relevant files

Enhancement

ConversationFilter.cs Add EndTime property to ConversationFilter                              src/Infrastructure/BotSharp.Abstraction/Repositories/Filters/ConversationFilter.cs Add EndTime property of type DateTime? to the filter class +1/-0      MongoRepository.Conversation.cs Implement EndTime filtering in MongoDB repository                src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs Add filtering logic for EndTime using MongoDB Lte operator Filter conversations by CreatedTime <= EndTime when EndTime is provided +4/-0

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Logic Validation The EndTime filtering logic uses Lte (less than or equal) operator on CreatedTime. This means conversations created exactly at the EndTime will be included. Verify this is the intended behavior and consider if it should be Lt (less than) instead for exclusive end time filtering. if (filter?.EndTime != null) { convFilters.Add(convBuilder.Lte(x => x.CreatedTime, filter.EndTime.Value)); }

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Use exclusive upper bound filtering The EndTime filter should use Lt (less than) instead of Lte (less than or equal) to exclude conversations created exactly at the EndTime. This provides more intuitive behavior where EndTime represents an exclusive upper bound. src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs [396-399] if (filter?.EndTime != null) { - convFilters.Add(convBuilder.Lte(x => x.CreatedTime, filter.EndTime.Value)); + convFilters.Add(convBuilder.Lt(x => x.CreatedTime, filter.EndTime.Value)); } Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion to change from Lte (less than or equal) to Lt (less than) for the EndTime filter is a valid design choice that aligns with the common convention of using an exclusive upper bound for date ranges, which can make the API more intuitive for consumers.	Low
More