Skip to content

Fix Push dialogs into model context #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oceania2018 merged 2 commits into from
Mar 15, 2025
Merged

Fix Push dialogs into model context #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c73d0
Fix Push dialogs into model context
Mar 15, 2025
aa49f9b
Merge branch 'master' of https://github.com/hchen2020/BotSharp
Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/Infrastructure/BotSharp.Core.Realtime/Services/RealtimeHub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,7 @@ await _completer.Connect(_conn,
onModelReady: async () =>
{
// Not TriggerModelInference, waiting for user utter.
await _completer.UpdateSession(_conn);

// Push dialogs into model context
foreach (var message in dialogs)
{
await _completer.InsertConversationItem(message);
}
var instruction = await _completer.UpdateSession(_conn);

// Trigger model inference if there is no audio file in the conversation
if (!states.ContainsState("init_audio_file"))
Expand All @@ -119,6 +113,16 @@ await _completer.Connect(_conn,
await _completer.TriggerModelInference("Reply based on the conversation context.");
}
}
else
{
// Push dialogs into model context
foreach (var message in dialogs)
{
await _completer.InsertConversationItem(message);
}

await _completer.TriggerModelInference($"{instruction}\r\n\r\nAssist user without repeating your previous statement.");
}
},
onModelAudioDeltaReceived: async (audioDeltaData, itemId) =>
{
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioStreamController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public async Task<TwiMLResult> InitiateStreamConversation(ConversationalVoiceReq

if (request.InitAudioFile != null)
{
instruction.SpeechPaths.Add($"twilio/voice/speeches/{request.ConversationId}/{request.InitAudioFile}");
instruction.SpeechPaths.Add(request.InitAudioFile);
}

await HookEmitter.Emit<ITwilioSessionHook>(_services, async hook =>
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/BotSharp.Plugin.Twilio/Services/TwilioService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ public VoiceResponse ReturnBidirectionalMediaStreamsInstructions(string conversa
}
else
{
response.Play(new Uri($"{_settings.CallbackHost}/{speechPath}"));
response.Play(new Uri($"{_settings.CallbackHost}/twilio/voice/speeches/{conversationalVoiceResponse.ConversationId}/{speechPath}"));
}
}
}
Expand Down
Loading