Prevent warning about regularise when using new loader. #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think this should go in the 1.8 release if at all possible. What do you reckon @rhattersley, @marqh? |
Merged
Member
|
👍 Thanks @ajdawson |
bjlittle
added a commit
that referenced
this pull request
Apr 14, 2015
Prevent warning about regularise when using new loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning about the deprecated
auto_regularisekeyword was being issued on all loads for the new grib loader. Since it is not supported at all in that loader it is pointless to display the warning. Instead I've added a note to the docstring to explain the keyword has no effect wheniris.FUTURE.strict_grib_load = Trueand moved the warning so it is only triggered for the old loader.