Skip to content

Overnight benchmarks remove ambiguity between file and commit names. #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Overnight benchmarks remove ambiguity between file and commit names. #4620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c830b5
Overnight benchmarks remove ambiguity between file and commit names.
trexfeathers Mar 4, 2022
0ebd7e3
Overnight benchmarks typo fix.
trexfeathers Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,13 @@ jobs:
cd benchmarks/.asv/performance-shifts
for commit_file in *
do
pr_number=$(git log "$commit_file"^! --oneline | grep -o "#[0-9]*" | tail -1 | cut -c 2-)
commit="${commit_file%.*}"
pr_number=$(git log "$commit"^! --oneline | grep -o "#[0-9]*" | tail -1 | cut -c 2-)
assignee=$(gh pr view $pr_number --json author -q '.["author"]["login"]' --repo $GITHUB_REPOSITORY)
title="Performance Shift(s): \`$commit_file\`"
title="Performance Shift(s): \`$commit\`"
body="
Benchmark comparison has identified performance shifts at commit \
$commit_file (#$pr_number). Please review the report below and \
$commit (#$pr_number). Please review the report below and \
take corrective/congratulatory action as appropriate \
:slightly_smiling_face:

Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def asv_compare(*commits):
# Dir is used by .github/workflows/benchmarks.yml,
# but not cached - intended to be discarded after run.
shifts_dir.mkdir(exist_ok=True, parents=True)
shifts_path = shifts_dir / after
shifts_path = (shifts_dir / after).with_suffix(".txt")
with shifts_path.open("w") as shifts_file:
shifts_file.write(shifts)

Expand Down