Skip to content

Conversation

@bjlittle
Copy link
Member

@bjlittle bjlittle commented Sep 17, 2025

🚀 Pull Request

Description

Addresses first of two parts of #6473 i.e., supporting masked aux coords for Cube.aggregated_by.

Follow-on separate pull-request will address supporting masked aux coords for Cube.collapsed.

  • Add unit test coverage

Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@bjlittle bjlittle marked this pull request as draft September 17, 2025 12:52
@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (69dee8a) to head (cc413bf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6706   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files          91       91           
  Lines       24467    24472    +5     
  Branches     4568     4569    +1     
=======================================
+ Hits        22092    22097    +5     
  Misses       1607     1607           
  Partials      768      768           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjlittle bjlittle removed this from 🚴 Peloton Sep 19, 2025
@bjlittle bjlittle moved this to 👀 In Review in 🦌 Iris 3.14 Sep 19, 2025
@bjlittle bjlittle marked this pull request as ready for review September 19, 2025 14:21
@bjlittle bjlittle linked an issue Sep 19, 2025 that may be closed by this pull request
@bjlittle bjlittle requested a review from ESadek-MO September 19, 2025 14:25
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all passing, and all makes sense. Thanks!

@ESadek-MO ESadek-MO merged commit 8ed2570 into SciTools:main Sep 23, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to 🏁 Done in 🦌 Iris 3.14 Sep 23, 2025
@bjlittle
Copy link
Member Author

@ESadek-MO Awesome, thanks 🎉

@bjlittle bjlittle deleted the agg-masked-aux branch September 24, 2025 13:53
ukmo-ccbunney added a commit to ukmo-ccbunney/iris that referenced this pull request Sep 25, 2025
* upstream/main:
  collapsed preserving masked aux coords (SciTools#6719)
  aggregated_by preserving masked aux coords (SciTools#6706)
  [pre-commit.ci] pre-commit autoupdate (SciTools#6720)
  Fix UCAR linkcheck failures. (SciTools#6718)
  Bump pypa/gh-action-pypi-publish from 1.12.4 to 1.13.0 (SciTools#6709)
  Bump scitools/workflows from 2025.09.3 to 2025.09.4 (SciTools#6708)
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Aggregating a masked auxiliary coordinate removes mask

2 participants