-
Notifications
You must be signed in to change notification settings - Fork 296
Enable callbacks for loading netcdf with multiple variables #6754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6754 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 91 91
Lines 24656 24659 +3
Branches 4618 4619 +1
=======================================
+ Hits 22264 22267 +3
Misses 1620 1620
Partials 772 772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested some ways to make the code cleaner, and (I think) easier to read.
Also some further tests.
Your earlier suggestion of adding some integration tests is also a good idea, I think.
But that can probably wait while we attend to other things, along with whatsnew content etc.
lib/iris/tests/unit/fileformats/netcdf/loader/test__translate_constraints_to_var_callback.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final small tweak, and all good !
🚀 Pull Request
Closes #6228