Add openjdk25 #554
Add openjdk25 #554
Conversation
WalkthroughUpdates the existing OpenJDK Scoop manifest to version 25 and adds a dedicated openjdk25.json manifest. Changes include updated download URLs, SHA256 checksums, extract directory, and checkver URL. Autoupdate and regex patterns remain consistent with prior configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
|
|
All changes look good. Wait for review from human collaborators. openjdk
openjdk25
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
bucket/openjdk.json (1)
4-4: Include GA build in version (e.g., 25-36) to align with checkver.replace.checkver produces "${version}-${build}" (e.g., 25-36). Keeping "version": "25" causes a mismatch and noisier updates.
- "version": "25", + "version": "25-36",bucket/openjdk25.json (1)
1-6: Pin version to GA build (25-36) for accuracy and consistency.- "version": "25", + "version": "25-36",Optional: align description wording with openjdk.json for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
bucket/openjdk.json(1 hunks)bucket/openjdk25.json(1 hunks)
🔇 Additional comments (7)
bucket/openjdk.json (3)
12-12: LGTM: extract_dir matches ZIP root (jdk-25).
18-18: LGTM: checkver.url updated to 25 page; regex/replace remain compatible.
8-9: Verified — URL and SHA256 match.
Downloaded the artifact and computed sha256 = 85bcc178461e2cb3c549ab9ca9dfa73afd54c09a175d6510d0884071867137d3 (matches openjdk.json); archive top-level dir = "jdk-25".bucket/openjdk25.json (4)
12-16: LGTM: extract_dir, PATH, and JAVA_HOME are correct.
17-21: LGTM: checkver regex/replace will yield 25-; matches autoupdate expectations.
22-32: LGTM: autoupdate templates and hash source are correct; extract_dir uses $matchVersion → jdk-25.
7-11: Verify URL and SHA‑256 for bucket/openjdk25.jsonCompute the SHA‑256 of the artifact at the URL and confirm it equals 85bcc178461e2cb3c549ab9ca9dfa73afd54c09a175d6510d0884071867137d3 (same as openjdk.json); also list the zip root entries to confirm expected JDK layout.
Run:
python - <<'PY'
import hashlib,zipfile
fn='openjdk25.zip'
h=hashlib.sha256()
with open(fn,'rb') as f:
for b in iter(lambda: f.read(8192), b''):
h.update(b)
print(h.hexdigest())
with zipfile.ZipFile(fn) as z:
print(sorted({p.split('/')[0] for p in z.namelist() if '/' in p})[:20])
PY
2 participants
Add
openjdk25and updateopenjdkto 25.JDK25 was released on 16.09.2025.
Summary by CodeRabbit
New Features
Chores