This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Ensure strings are always wrapped in quotes#441
Merged
7 commits merged intoJan 21, 2019
Merged
Conversation
This change ensures: - String values being unquoted and potentially being understood as numerical or other values - Empty strings being synonomous with null (now they're represented as "")
ghost
added
enhancement
ghost
requested review from
cakehurstryan,
pdaulbyscottlogic,
steve-tennantsl and
tyankovasc
harry-bedford
approved these changes
Jan 21, 2019
Contributor
|
Do we support escaped characters? If so is this something we should test for? |
Author
@cakehurstryan I tested the content @harryBedfordSL is introducing tests for the CSV writer on ticket #432 so we can add additional tests here, or after its complete, to prove the functionality. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures:
Tests performed: