enable end users to pass model instances for llm and embeddings model #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkamboj1
changed the title
lurenss
reviewed
May 2, 2024
|
|
||
| "azure": { | ||
| "gpt-3.5-turbo": 4096 | ||
| }, |
Member
There was a problem hiding this comment.
I think it would be cool to have all the avaible model on AzureAI, here the link Azure AI
| if isinstance(embedding_model, OpenAI): | ||
| embeddings = OpenAIEmbeddings( | ||
| api_key=embedding_model.openai_api_key) | ||
| elif isinstance(embedding_model, AzureOpenAIEmbeddings): |
Member
There was a problem hiding this comment.
DId you have the chanche to test with azure embedding model? Did you use text-ada? does it work properliy? :)
Contributor
Author
There was a problem hiding this comment.
yes, I used text-ada, have attached example as well.
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123 Hi @VinciGit00, I have added support for passing model instances as well, means optionally end user can pass llm / embedding instances as well. So, using this we can support Azure OpenAI as well.