Pass common params to nodes in graph #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
epage480
commented
May 5, 2024
epage480
commented
- Added update_config function to base_node.py
- Added set_common_params function to abstract_graph.py
- Changed key value in node_config to match the attribute ("llm" -> "llm_model")
- Some node files varied between "llm" and "llm_model", changed so all nodes consistently use "llm_model"
- Updated graphs and examples to use the naming scheme and take advantage of set_common_params function (mostly removing "verbose" and "headless" in the nodes. We can probably adapt "llm_model", "embedder_model" and others common parameters as well but this would require making node_config an optional parameter for most nodes.
- NOTE: I was able to run all openai examples (except for custom_graph_openai.py which was broken before my changes) and the single_node files but I am currently unable to get the test files running due to an environment error (I'm currently on windows and cannot run ubuntu)
|
🎉 This PR is included in version 0.9.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.10.0-beta.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.