feat: Remove deprecated methods #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
reviewed
Dec 15, 2022
| @@ -431,7 +431,7 @@ assert_eq!( | |||
|
|
|||
| ```rust | |||
| let query = Query::select() | |||
| .expr(Func::sum(Expr::tbl(Char::Table, Char::SizeH))) | |||
| .expr(Func::sum(Expr::col((Char::Table, Char::SizeH)))) | |||
billy1624
reviewed
Dec 15, 2022
| @@ -456,7 +456,7 @@ | |||
| //! ```rust | |||
| //! # use sea_query::{*, tests_cfg::*}; | |||
| //! let query = Query::select() | |||
| //! .expr(Func::sum(Expr::tbl(Char::Table, Char::SizeH))) | |||
| //! .expr(Func::sum(Expr::col((Char::Table, Char::SizeH)))) | |||
billy1624
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
LGTM Thanks!! @ikrivosheev
Note to merge master: this should goes into the 0.29.0 release
|
@billy1624 hello! I did:
|
|
Got it! Thanks! @ikrivosheev |
🎉 Released In 0.29.0 🎉Your participation is what makes us unique; your adoption is what drives us forward. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Expr::tbl,Expr::greater_than,Expr::greater_or_equal,Expr::less_than,Expr::less_or_equal,Expr::into_simple_expr,SimpleExpr::equalsandSimpleExpr::not_equalsInsertStatement::exprs,InsertStatement::exprs_panicOnConflict::update_value,OnConflict::update_values,OnConflict::update_expr,OnConflict::update_exprsUpdateStatement::exprs,UpdateStatement::col_expr,UpdateStatement::value_expr