Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: get_random_uuid -> gen_random_uuid #569

Merged
merged 1 commit into from
Dec 29, 2022
Merged

fix!: get_random_uuid -> gen_random_uuid #569

merged 1 commit into from
Dec 29, 2022

Conversation

siketyan
Copy link
Contributor

BREAKING CHANGE: get_random_uuid will be unavailable

PR Info

  • Dependencies:
  • Dependents:

New Features

N/A

Bug Fixes

  • Resolve PgFunc::GetRandomUUID generates GET_RANDOM_UUID function which does not exist actually

Breaking Changes

  • These names were changed, and old ones will unavailable after this changes
    • PgFunction::GetRandomUUID -> PgFunction::GenRandomUUID
    • PgFunc::get_random_uuid -> PgFunc::gen_random_uuid

Changes

N/A

@siketyan
fix!: get_random_uuid -> gen_random_uuid
678d1a7 
BREAKING CHANGE: get_random_uuid will be unavailable
@tyt2y3
Copy link
Member

tyt2y3 commented Dec 29, 2022 •
edited
Loading

@ikrivosheev We might want to keep the old method and put a #[deprecated(since = "0.29.0")] tag?

@tyt2y3 tyt2y3 requested a review from ikrivosheev December 29, 2022 06:40
ikrivosheev
ikrivosheev approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siketyan thank you so much! My bad...

@ikrivosheev ikrivosheev merged commit b020f16 into SeaQL:master Dec 29, 2022
@siketyan siketyan deleted the fix/gen-random-uuid branch December 29, 2022 11:05
@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres GEN_RANDOM_UUID
3 participants
@siketyan @tyt2y3 @ikrivosheev