Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quoted string bug while inserting array of strings to Postgres #576

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Fix quoted string bug while inserting array of strings to Postgres #576

merged 5 commits into from
Jan 19, 2023

Conversation

sh-soltanpour
Copy link
Contributor

PR Info

  • Dependencies:
  • Dependents:

New Features

Bug Fixes

  • Fix the bug while generating an insert query string. The result should be like VALUES '{val}' while now it's like VALUES '{'val'}'.

Breaking Changes

Changes

@sh-soltanpour
Copy link
Contributor Author

Hi @billy1624 @ikrivosheev,

I believe this is ready for review, I'm not sure if I have access to change the status to 'Ready for review' or not.

Thanks.

tyt2y3
tyt2y3 reviewed Jan 11, 2023
View reviewed changes
tests/postgres/query.rs Outdated Show resolved Hide resolved
ikrivosheev
ikrivosheev approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sh-soltanpour thank you! LGTM! @tyt2y3 or @billy1624 can someone review the PR?)

@sh-soltanpour sh-soltanpour requested a review from tyt2y3 January 17, 2023 04:24
@sh-soltanpour
Copy link
Contributor Author

Thanks for your approval!
I think it's ready to merge @ikrivosheev. Thanks

@tyt2y3 tyt2y3 merged commit 00cfaac into SeaQL:master Jan 19, 2023
@tyt2y3 tyt2y3 mentioned this pull request Apr 8, 2023
Merged
billy1624 pushed a commit that referenced this pull request Apr 8, 2023
@sh-soltanpour @billy1624
Fix quoted string bug while inserting array of strings to Postgres (#576
4f32add 
)

* Fix quoted string bug while inserting array of strings to Postgres

* Add string array field to the test database

* Run rustfmt on changed files

* Use ARRAY [] syntax for inserting in array

* Update array syntax in test cases
@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error inserting document containing array in Postgres
3 participants
@sh-soltanpour @tyt2y3 @ikrivosheev