-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement SqlxBinder for WithQuery #580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matt-phylum hello! Thank you for the PR, can you also add to sea-query-rusqlite
and sea-query-postgres
?
@matt-phylum hello, any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matt-phylum thank you! LGTM!
@ikrivosheev Did you include this in the latest release? Currently, on the latest release |
No. It is not currently in 0.28 but I think we can include that |
implement SqlxBinder for WithQuery
🎉 Released In 0.29.0 🎉Your participation is what makes us unique; your adoption is what drives us forward. |
🎉 Released In 0.29.1 🎉Thank you everyone for the contribution! |
There aren't any tests included. I think the examples should be updated to include a
WITH
query, but to do it properly would probably involve changing the schema of the example database.PR Info
WithQuery
not usable withSqlxBinder
#577New Features
Bug Fixes
WithQuery
can be used withbuild_sqlx
the same way as the other statement types.Breaking Changes
Changes