Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bitwise aggregate functions #582

Merged

Conversation

tooboredtocode
Copy link
Contributor

@tooboredtocode tooboredtocode commented Jan 12, 2023

New Features

  • Bitwise Aggregate Functions
    • Bitwise And
    • Bitwise Or

Breaking Changes

This change is backwards compatible

Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tooboredtocode hello! Thank you for the PR. If I understand correctly functions support only by Mysql and Postgres.
I think, it's better to add it here: https://github.com/SeaQL/sea-query/tree/master/src/extension

@billy1624 @tyt2y3 what do you think about it?

@tyt2y3
Copy link
Member

tyt2y3 commented Jan 31, 2023

Umm the idea has been "If 2 out of 3 backends support it we can still put it on the common API. If the feature is specific to 1 backend then we put them behind extensions"

@tooboredtocode
Copy link
Contributor Author

It might be worth putting it behind the mysql and postgres features, what do you think?

Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tooboredtocode thank you! LGTM!

@ikrivosheev ikrivosheev merged commit 889828b into SeaQL:master Feb 1, 2023
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants