Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile test_cfg when needed and hide it from docs #584

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Compile test_cfg when needed and hide it from docs #584

merged 1 commit into from
Jan 18, 2023

Conversation

billy1624
Copy link
Member

Breaking Changes

  • tests_cfg module available if and only if you enabled tests-cfg feature

Hide implementors that are purely for testing purposes:

image

https://docs.rs/sea-query/latest/sea_query/types/trait.Iden.html#implementors

@billy1624 billy1624 self-assigned this Jan 13, 2023
@billy1624 billy1624 marked this pull request as ready for review January 13, 2023 05:14
ikrivosheev
ikrivosheev approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 is a good catch! LGTM!

@billy1624 billy1624 merged commit f04cca9 into master Jan 18, 2023
@billy1624 billy1624 deleted the tests-cfg branch January 18, 2023 10:12
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @ikrivosheev