Fix: Dropping multiple types in Postgres

[PreetamSing]

Bug Fixes

• Following code in Rust omits the comma in SQL statement, which causes error from Postgres (as of sea-query version 0.28.3). This issue has been fixed.

use sea_query::{extension::postgres::Type, *};

#[derive(Iden)]
enum KycStatus {
   #[iden = "kyc_status"]
   Type,
   Pending,
   Approved,
}

#[derive(Iden)]
enum FontFamily {
   #[iden = "font_family"]
   Type,
   Aerial,
   Forte,
}

assert_eq!(
    Type::drop()
        .if_exists()
        .names([
            SeaRc::new(KycStatus::Type) as DynIden,
            SeaRc::new(FontFamily::Type) as DynIden,
        ])
        .cascade()
        .to_string(PostgresQueryBuilder),
    r#"DROP TYPE IF EXISTS "kyc_status""font_family" CASCADE"#
);

Changes

• Add comma if multiple names are passed to TypeDropStatement.
• Doc-test/example for dropping multiple types in single TypeDropStatement.

Other considerations

• I'm fairly new to this code and have, sort of, reverse engineered this bug to fix it. Hence, I'm not fully aware of how my code can affect other things, though all the tests passed.
• Please update the dependency in sea-orm crate, if you merge this.

[ikrivosheev]

@PreetamSing hello! Thank for the PR. A small suggestion)

[ikrivosheev]

@PreetamSing thank you! LGTM!

[ikrivosheev]

@billy1624 @tyt2y3 can we make a small patch release with the fix?

[billy1624]

Hey @PreetamSing, thanks for contributing!! What your thoughts on this? https://github.com/SeaQL/sea-query/pull/623/files#r1142999511

[billy1624]

@billy1624 @tyt2y3 can we make a small patch release with the fix?

I agree, we should backport this to 0.28.x

[ikrivosheev]

@billy1624, can you review the PR?

[tyt2y3]

Thank you for the contribution.

[tyt2y3]

I agree, we should backport this to 0.28.x

Agreed.

[ikrivosheev]

@billy1624 @tyt2y3 I merged changes and updated: https://github.com/SeaQL/sea-query/blob/0.28.x/CHANGELOG.md